Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

What do you think about unifying data types of 'collapsedlcon' in collapsible widget? #6709

@allsteady

Description

@allsteady

Hi all.

According to the following API document,
collapsedlcon type in Options of Collapsible widget is defined as two kind.


API : https://github.com/jquery/api.jquerymobile.com/blob/1-4/entries/collapsible.xml (line: 138~150)
collapsedIconType: String or Boolean
Default: "plus"

Multiple types supported:
• String: The name of the icon you wish to use.
• Boolean: In addition to an icon name, you can also set this option to false. In that case, the collapsible will not have an icon in either the expanded or collapsed state. Add data-collapsed-icon="false" to the collapsible widget to set the option to false via the data attribute.


I think that a user will be confused by this option.
And widget may have a possibility to act incorrectly.
Such as, If a user assign the value to "false" of String type, the icon would be not disappeared.

Therefore, I think that we unify into the String type.

This issue is concerned with #6708.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions