Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

Popup: Dynamic popup demo broken #7336

Closed
gabrielschulhof opened this issue Apr 23, 2014 · 0 comments
Closed

Popup: Dynamic popup demo broken #7336

gabrielschulhof opened this issue Apr 23, 2014 · 0 comments
Assignees
@gabrielschulhof
Labels
Component: Popup Demos
Milestone
1.4.3

Comments

@gabrielschulhof
Copy link

You need to properly enhance the popup first. First reported in #7290.
@gabrielschulhof gabrielschulhof added this to the 1.4.3 milestone Apr 23, 2014
@gabrielschulhof gabrielschulhof self-assigned this Apr 23, 2014
gabrielschulhof pushed a commit that referenced this issue Apr 23, 2014
Popup: Correctly enhance popup and its contents before opening
b8431e1 
This is a better fix than the one provided in the original PR for this, because
it avoids the use of .enhanceWithin(), and it moves the image width/height
retrieval to popupbeforeposition, which is correct, because during creation the
popup is truncated to 1px x 1px.

Closes gh-7290
Fixes gh-7336
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gabrielschulhof gabrielschulhof

Labels
Component: Popup Demos
Projects
None yet
Milestone
1.4.3
Development

No branches or pull requests
1 participant
@gabrielschulhof