Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

Toolbar: Add option "external" #8428

Open
@gabrielschulhof

Description

@gabrielschulhof

external:

  • null: use current code (roughly this.element.closest(".ui-page")) to detect whether you're in a page.
  • true: Assume you're external
  • false: Assume you're internal

The reason we need this is that external toolbars set all current and future pages to position: relative, however, if a toolbar is instantiated on a floating piece of DOM, it will not find a parent page, thus affecting all current pages.

Additionally, the code for setting the pages as relative should key off of this.document instead of running a global selector, i.e., this.document.find( ... )... (in toolbar.js:_setRelative())

Metadata

Metadata

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions