Fixed dialog theme inheritance (issue 1375)

[BradBroulik]

Users can now override the dialog's theme with data-theme attributes.

[scottjehl]

Thanks! I could be wrong, but I believe this is fixed in Master as of today. Can you confirm, and if so, would you mind resubmitting your pull with just the unit tests? thanks!

[BradBroulik]

Appreciate the update. The new page.sections has chanced the precedence rules for the header/footer inheritance. This is causing my tests to fail so I want to verify what the expected precedence order should be.

Previously, the header theme precedence was:

1. header's data-theme
2. page/dialog data-theme
3. default to theme 'a'

Currently, the header theme precedence is (2 & 3 are now swapped):

1. header's data-theme
2. $.mobile.page.prototype.options.headerTheme = 'a'
3. page/dialog data-theme

What's the expected theme precedence?

Thanks,
Brad

---

From: scottjehl reply@reply.github.com
To: bbroulik@yahoo.com
Sent: Wednesday, July 20, 2011 6:15 PM
Subject: Re: [jquery-mobile] Fixed dialog theme inheritance (issue 1375) (#2108)

Thanks! I could be wrong, but I believe this is fixed in Master as of today. Can you confirm, and if so, would you mind resubmitting your pull with just the unit tests? thanks!

Reply to this email directly or view it on GitHub:
#2108 (comment)