This repository was archived by the owner on Oct 8, 2021. It is now read-only.
Consider data-role when picking page transition in changePage#2152
Merged
gseguin merged 1 commit intojquery-archive:masterfrom Jul 27, 2011
webmynd:master
Merged
Consider data-role when picking page transition in changePage#2152gseguin merged 1 commit intojquery-archive:masterfrom webmynd:master
gseguin merged 1 commit intojquery-archive:masterfrom
webmynd:master
Conversation
Re-use existing "isDialog" variable in changePage, instead of just looking at settings.role.
gseguin
added a commit
that referenced
this pull request
Jul 27, 2011
Consider data-role when picking page transition in changePage
Contributor
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-use existing "isDialog" variable in changePage,
instead of just looking at settings.role.