This repository was archived by the owner on Oct 8, 2021. It is now read-only.
Fix issue of the select menu not closing on Chrome#2173
Merged
johnbender merged 1 commit intojquery-archive:masterfrom Aug 3, 2011
Merged
Fix issue of the select menu not closing on Chrome#2173johnbender merged 1 commit intojquery-archive:masterfrom
johnbender merged 1 commit intojquery-archive:masterfrom
Conversation
…out of the menu or on the selected option
Contributor
|
Thanks for this fix, I was wondering if I was going to have to dig into what the problem was. To confirm this go to http://jquerymobile.com/test/#/test/docs/forms/selects/index.html in chrome, scroll down to the multi select list at the bottom (shipping methods), select all the items and try to close the select list. |
Contributor
Author
|
Ok I tested the multi select list and the fix work for it too. The list can be closed correctly either by using the close button or clicking out of the list. |
johnbender
added a commit
that referenced
this pull request
Aug 3, 2011
Fix issue of the select menu not closing on Chrome - Fixes 2198, 2194, 2197
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Chrome when we click out of the menu or on the already selected option, the select menu is not closed. The menu is closed when the mouse move over another option but if the menu have only one option, it can't be closed.
Adding self.list.appendTo( self.listbox ) before calling self._focusButton() as its done for the pagehide of the full page menu seem to fix the issue. But maybe a better solution would be to put self.list.appendTo( self.listbox ) in _focusButton() like it was before.