Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

Fix issue of the select menu not closing on Chrome#2173

Merged
johnbender merged 1 commit intojquery-archive:masterfrom
SamuelKC:selecthidefix
Aug 3, 2011
Merged

Fix issue of the select menu not closing on Chrome#2173
johnbender merged 1 commit intojquery-archive:masterfrom
SamuelKC:selecthidefix

Conversation

@SamuelKC
Copy link
Contributor

On Chrome when we click out of the menu or on the already selected option, the select menu is not closed. The menu is closed when the mouse move over another option but if the menu have only one option, it can't be closed.

Adding self.list.appendTo( self.listbox ) before calling self._focusButton() as its done for the pagehide of the full page menu seem to fix the issue. But maybe a better solution would be to put self.list.appendTo( self.listbox ) in _focusButton() like it was before.

@jgable
Copy link
Contributor

jgable commented Jul 29, 2011

Thanks for this fix, I was wondering if I was going to have to dig into what the problem was.

To confirm this go to http://jquerymobile.com/test/#/test/docs/forms/selects/index.html in chrome, scroll down to the multi select list at the bottom (shipping methods), select all the items and try to close the select list.

@SamuelKC
Copy link
Contributor Author

SamuelKC commented Aug 1, 2011

Ok I tested the multi select list and the fix work for it too. The list can be closed correctly either by using the close button or clicking out of the list.

johnbender added a commit that referenced this pull request Aug 3, 2011
Fix issue of the select menu not closing on Chrome - Fixes 2198, 2194, 2197
@johnbender johnbender merged commit 3dbb018 into jquery-archive:master Aug 3, 2011
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants