Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

Slider: Support for a range-theme #2381

Closed
wants to merge 5 commits into from

Conversation

hpbuniat
Copy link
Contributor

@hpbuniat hpbuniat commented Sep 2, 2011

I added a third theme to the ui.slider to highlight the part between slider-start and the current handle, like the jquery-ui slider does.

…ween slider-start and current handle-position
hpbuniat added a commit to hpbuniat/jquery-mobile that referenced this pull request Sep 12, 2011
@v00d00j3st3r
Copy link

+1

@johnbender
Copy link
Contributor

@hpbuniat

Looks super nice (especially the the test :D), any chance you can resubmit this without the extra merge commits? Ie, new branch and cherry pick the single relevant commit.

@toddparker

Is this something we want to support from a usability perspective?

@toddparker
Copy link
Contributor

I was just saying that I wanted to add this as an option at some point so this is fantastic. Just confirming - this feature is activated by adding the rangeTheme to the input, right? Does this add anything else to the API?

In terms of docs, I'd like to leave the first slider alone because it is meant to show the default slider. We can add this as another demo below. This new data- attr needs to be documented here:
http://jquerymobile.com/test/docs/api/data-attributes.html

@hpbuniat
Copy link
Contributor Author

@johnbender
I'll move this to a new branch, to get rid of those extra commits.

@toddparker
Right, this is activated via the range-theme attribute. Of course the theme must contain a corresponding css-class. When creating the new branch, i'll cleanup the docs in one go.

@johnbender
Copy link
Contributor

@hpbuniat

Alright, I'm going to close this pull request in expectation of your update.

@johnbender johnbender closed this Dec 14, 2011
hpbuniat added a commit to hpbuniat/jquery-mobile that referenced this pull request Dec 18, 2011
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants