This repository was archived by the owner on Oct 8, 2021. It is now read-only.
Fix for disappearing notext icons in IE7/WP7.#2560
Merged
scottjehl merged 3 commits intojquery-archive:masterfrom Sep 28, 2011
Merged
Fix for disappearing notext icons in IE7/WP7.#2560scottjehl merged 3 commits intojquery-archive:masterfrom
scottjehl merged 3 commits intojquery-archive:masterfrom
Conversation
…indent: -9999px” set on the buttons themselves, which was causing IE to hide the icons (as they’re inline). Since it doesn’t look like text can possibly exist outside of .ui-btn-text, it should be safe to remove it.
|
Nice goin' Mat. Pulling. |
scottjehl
pushed a commit
that referenced
this pull request
Sep 28, 2011
Fix for disappearing notext icons in IE7/WP7.
|
This fix introduces a new bug, because now a button with data-iconpos="notext" and class="ui-btn-right" shows as icon button AND text button on screens greater than 999px. To solve this problem change .ui-btn-icon-notext .ui-btn-text { position: absolute; left: -999px; } to the value -9999px (like it was with the text-indent). |
Wilto
added a commit
to Wilto/jquery-mobile
that referenced
this pull request
Oct 11, 2011
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, accidentally lumped two fixes into this request. Still getting the hang of this “social coding” business, as you guys can probably tell.
• Fixes #1230 — Looks like there was an extranious “text-indent: -9999px” set on the buttons themselves, which was causing IE to hide the icons (as they’re inline). Since it doesn’t look like text can possibly exist outside of .ui-btn-text, it should be safe to remove it.
• Slight tweak to styling of buttons with data-iconpos=[top/bottom] — Todd and I noticed that these buttons looked a little off, so I made a quick CSS change to pull the icons and associated text closer to the center of the button.