added animation and customizable icons to collapsible#2611
added animation and customizable icons to collapsible#2611ducas wants to merge 11 commits intojquery-archive:masterfrom
Conversation
Conflicts: js/jquery.mobile.collapsible.js
|
We'll probably wait until post 1.0 to add any more features, though I do appreciate the value here. I've created a wiki entry under feature requests under Collapsible: https://github.com/jquery/jquery-mobile/wiki/Feature-Requests As a side note, It's really hard for us to sort though pull requests with merge commits like this because we have to be sure of all the code that's going into the library. I would create a new branch from master, cherry-pick the commits over to it and resubmit the pull request from the new branch. If you need some direction on how to go about doing that I'm glad to help, just post back here. |
|
Hi John, Thanks for that. Still getting my head around git. I understand the reluctance to pull in new features so I'll hold off submitting a new one until 1 goes gold. Cheers. |
|
Git can be a bear at times, so please do shoot me a message if you want to resubmit and I'll be happy to help! |
No description provided.