This repository was archived by the owner on Oct 8, 2021. It is now read-only.
Fix for issue 1383 #2621
Closed
Fix for issue 1383 #2621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -180,7 +180,7 @@ | |||
|
|
|||
| //set location hash to path | |||
| set: function( path ) { | |||
| location.hash = path; | |||
| location.hash = jQuery.browser.mozilla ? escape(path) : path; | |||
There was a problem hiding this comment.
I'm not sure this is the proper place for this escape. We get paths from several places in the system, so we need to make sure we don't end up escaping something that may already be escaped. We'll need to discuss this amongst the group.
|
I think we need to address escaping these path's in general (for data-url's as well). Thanks for the submission either way! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
this patch fixes: #1383
Since this is a firefox only problem that mini patch should work