Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

Small error and optimization to default theme css#302

Closed
beausmith wants to merge 3 commits intojquery-archive:masterfrom
beausmith:master
Closed

Small error and optimization to default theme css#302
beausmith wants to merge 3 commits intojquery-archive:masterfrom
beausmith:master

Conversation

@beausmith
Copy link
Contributor

While converting the stylesheets to SASS I found:

  • a few missing commas in the jquery.mobile.button.css. Small but critical syntax issue.
  • unnecessary specificity in the css related to .ui-checkbox and .ui-radio styling.

* jquery/master: (27 commits)
  Fixed 138 - transition: fix flip (and cube?)
  Fixed jquery-archive#117
  changed #fff to #ffffff in ui-body-b and ui-body-e because IE has issues with shorthand notation in filters.
  Small improvement to keep from querying the DOM more than once for the data-role=pages elements.
  added support for enable and disable methods
  changed disabled class to ui-disabled, dropping the "state" portion to fit with the new conventions
  rewrote checkboxradio to use widget factory. renamed method checkboxradio and updated page plugin to match
  rewrote navbar with widget factory
  added check to make sure active link isn't in the new activepage (such as when it's appended to the new page for persistence), before removing class
  converted customButton plugin to widget factory (note: this is just the plugin for native button elements, not to be confused with the buttonMarkup plugin).
  moved line where # is removed to prevent base url prefixing on local anchor links
  moved active class removal code into function - now called after ajax error as well as successful page change
  made sure local # urls go through the regular page nav path, and only update the hash on success
  removed a few chars from condition. Thx @JeffreyWay for suggestions on the last few commits.
  used cached version of $this
  removed nullLink var
  updated regexp to test for protocol or # at beginning of url.
  simplified attr get/check
  Fixed broken <code> element.
  commented-out the call to _numberItems, as it doesn't yet exist in the listview rewrite
  ...
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant