Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

Fix license version and zip folder#3094

Merged
gseguin merged 2 commits intojquery-archive:masterfrom
eddiemonge:makefile
Nov 18, 2011
Merged

Fix license version and zip folder#3094
gseguin merged 2 commits intojquery-archive:masterfrom
eddiemonge:makefile

Conversation

@eddiemonge
Copy link
Contributor

No description provided.

@gseguin
Copy link
Contributor

gseguin commented Nov 17, 2011

One thing I noticed is that there is a @VERSION in the jQuery UI header. Is that going to be a problem? Should we hard code it since it's not very likely to vary?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're not out of tmp yet

@eddiemonge
Copy link
Contributor Author

The @Version is something I brought up before. It has nothing to do with the jqm build process. That version should be the version of jQueryUI's widget factory that we grabbed.

@gseguin
Copy link
Contributor

gseguin commented Nov 17, 2011

Yep and my question was can we replace it with the actual version of the jQuery UI component if we know it?

@eddiemonge
Copy link
Contributor Author

the Zipped files are fixed. See http://code.jquery.com/mobile/1.0/jquery.mobile-1.0.zip. I tested both the normal zip and the docs fix and it fixes it on my end.

I tried using -j and in the end the only thing that worked is the cd. There isn't a need to cd back up since its spawned in its own process. Found that out the long way.

@gseguin
Copy link
Contributor

gseguin commented Nov 17, 2011

oh ok, sorry... obviously I don't write enough Makefile these days ;)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that double $ intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, its needed to do inline shell commands

gseguin added a commit that referenced this pull request Nov 18, 2011
Fix license version and zip folder
@gseguin gseguin merged commit c693561 into jquery-archive:master Nov 18, 2011
@eddiemonge
Copy link
Contributor Author

As for the jQuery UI issue: #2838

@gseguin
Copy link
Contributor

gseguin commented Nov 18, 2011

Thanks Eddie!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants