Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

Generates right home links#3115

Closed
shemigon wants to merge 1 commit intojquery-archive:masterfrom
shemigon:master
Closed

Generates right home links#3115
shemigon wants to merge 1 commit intojquery-archive:masterfrom
shemigon:master

Conversation

@shemigon
Copy link

Is it possible to provide tests on it?

@shemigon shemigon closed this Nov 19, 2011
@toddparker toddparker reopened this Nov 19, 2011
@toddparker
Copy link
Contributor

What I meant to say is you closed this, but I'm not sure why.

@shemigon
Copy link
Author

I wanted to add the patch to the existing ticket but this duplicated one's been created. What is the right thing?

@eddiemonge
Copy link
Contributor

As is, it looks like this isn't correct. Not all ../../ should be replaced with index.html. Some could be for links or other resources.

@eddiemonge
Copy link
Contributor

It would be better to go through and add index.html to all the links in the docs, not in the build script. However, index.html is the default file that is served when you browse to any directory (< a href="/">) on about 95% of web servers (made up stat but its probably lower than the actual number) so adding the index.html is kind of superfluous. It seems like it would only affect server-less browsing, in which case, the index.html missing isnt the issue.

@eddiemonge
Copy link
Contributor

proposed fix #3117

@johnbender johnbender closed this Nov 22, 2011
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants