Update to select menu placeholder logic

[lukeb]

... option. Also remove getAttribute('value') in favor of $this.val()

[johnbender]

@lukeb

Thanks for the submission.

What issue are you addressing here? I'm having a difficulty figuring it out from the alterations, commit msg, and pull request description.

[edit] aside from not using .val which is odd, but doesn't help me understand the other alterations.

[lukeb]

Currently, even if you add the data-placeholder="false" attribute to a select element, it still treats it as a placeholder if it matches the other logic checks. This is why we need to use $this.jqmData( "placeholder" ) !== false for the check first.

[johnbender]

@lukeb

I think the idea is that if you don't want a given element to be the placeholder you should define another element as the placeholder explicitly. I'm going to close this one.

[lukeb]

Please reopen. You should be able to omit specific select elements from becoming a placeholder. The current logic is flawed, as you may not want an element to be the placeholder, even if it meets the current logic to setting to a placeholder. Please take a look at the diff and compare the old code with the new.

Also, this pull requests swaps out getAttribute("value") in favor of val();