This repository was archived by the owner on Oct 8, 2021. It is now read-only.
fix css in touch-overflow example#3165
Merged
toddparker merged 1 commit intojquery-archive:masterfrom Nov 25, 2011
Merged
Conversation
Contributor
|
Looks good, but I'm curious why setting left and right to 0 works. Do you know? |
Contributor
Author
|
The scrollable Element is set to position:absolute. Absolute positioned block elements don't constrain their width to the parent. Setting left/right makes it constrain to the body-element which is in our case identical to the viewport. I just found another issue with the top-position of not-inset lists. I'll push a fix for that, too, soon. Am 25.11.2011 um 17:44 schrieb Todd Parker reply@reply.github.com:
|
toddparker
added a commit
that referenced
this pull request
Nov 25, 2011
fix css in touch-overflow example. Thanks MaZderMind!
Contributor
|
Gotcha. We appreciate the help, keep 'em coming. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi
This fixes a bug with lists not beeing fit into the viewport width anymore when using touchOverflowEnabled on iOS5.
With 1.0 it looks like this:
http://mazdermind.de/temp/jqmobile/touch-overflow/with-1.0.html
http://mazdermind.de/temp/jqmobile/touch-overflow/with-1.0.png (iPhone 4s)
With this pull it looks like this:
http://mazdermind.de/temp/jqmobile/touch-overflow/with-fix.html
http://mazdermind.de/temp/jqmobile/touch-overflow/with-fix.png (iPhone 4s)
Possibly this fixes #2744, too.
Regards,
Peter