Fix Issue #2084 option to not-include dialog close icon#3260
Fix Issue #2084 option to not-include dialog close icon#3260dannyc wants to merge 2 commits intojquery-archive:masterfrom
Conversation
1) iconpos for close button- defaults to notext. 2) includeCloseBtn- defaults to true. At moment there is a closeBtnText option, but text will never be shown since iconpos is always notext! Currently anyone who doesn't want the default close icon button is stuck or must do some catching and hiding of the element. Not so intuitive. Default close button is not always wanted. Also, the window.hisory.back() is always wanted. Now users can do whatever they want.
…and include examples.
|
Can submit two pull requests? One for the feature that addresses #2084 and one to correct the Also, if you're feeling adventurous we love when people add tests. In any case thanks for the pull request, and please report back here if you create another two so that we can close this one. |
There was a problem hiding this comment.
We'd probably want to avoid the creation of the element all together on line 18. Otherwise the css suggestion of setting display: none is equivalent.
|
I commented on the close btn option alteration, and I'm going to close this in favor of opening two new pull requests for each change. Thanks for the pr and please do resubmit. |
Two issues here. First is issue #2084 Dialog close icon is always added even if not desired. Two, some how this slipped through over time- there is an option "close btn txt" but the text is never shown since the iconpos is hardcoded to "notext"!
Solution:
Add two new options:
Reasons why a person would not want the close icon button can vary, but window.hisory.back() is now always wanted. Now users can do whatever they want there, no button, button on the right, button with different icon, and attach whatever event handling they want to it.