Added support for data-filter and data-filter-placeholder on regular... #3480
Conversation
…selects when data-native-menu="false"
|
Thank you for the pull request. Do you have tests for this? or a jsbin showing the feature? Also, this seems to contain not only the feature in the title but also some refactoring (string concat). Could you split that commit into smaller commits as it makes it easier to track bugs. |
|
Sorry, I am on the holiday for the next two weeks. Good luck with the changes :) |
|
All good? |
|
For a change this large we'd normally ask you to write some tests. There's test suite at /tests/unit/select/ that you can start at. Otherwise it's going to be a while before we get to it since we have to make sure everything is working as expected. |
|
@dotnetwise - have you had a chance to look at writing tests for this? Seems like a cool feature, but we do need to have good test coverage to pull this in. Appreciate the contribution! |
|
Closing due to inactivity. |
…t and the selected option. This way you can customize it with i.e. images. This change is along with this one: jquery-archive/jquery-mobile#3480 (commits) For a demo: http://www.dotnetwise.com/tryAndError/jquery.mobile/select.filter/
…t and the selected option. This way you can customize it with i.e. images. This change is along with this one: jquery-archive/jquery-mobile#3480 (commits) For a demo: http://www.dotnetwise.com/tryAndError/jquery.mobile/select.filter/
...selects when data-native-menu="false"