This repository was archived by the owner on Oct 8, 2021. It is now read-only.
ButtonMarkup Cleanup#3773
Merged
gseguin merged 2 commits intojquery-archive:masterfrom Mar 10, 2012
eddiemonge:patch-2
Merged
Conversation
… it. Save a character, ride a ternary. roundaboutly fixes ui-fullsize class never being applied
Contributor
There was a problem hiding this comment.
Can we move that if down to line 98 and have:
if ( buttonElements ) {
el.removeClass( buttonElements.bcls || "" );
} else {
buttonInner.appendChild( buttonText );
}
Contributor
Author
There was a problem hiding this comment.
i didnt know what was in buttonElements.bcls so i was hesitant to move it in case it has ui-link in it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logically group buttonClass creations while fixing ui-fullsize class never being applied.
Also group iconClass creations.
Who uses curly brace-less if statements?