This repository was archived by the owner on Oct 8, 2021. It is now read-only.
Closed
Conversation
Contributor
|
Whats the idea of those if-statements? Isn't it to fail silently when those modules are missing? I rather have an error message about some missing module then something not working at all and not telling me whats going on. |
Author
|
Apache gives me an 500 'Internal Server Error', so I had to look in the logs to find the actual configuration error. It was a bit a shlep for me to do this, and I would have preferred the config errors to fail silently. But I do understand others preference on this. |
Contributor
|
If it fails silently and nothing works, thats worse. Much better would be to output an actual message directly in the browser about the missing module. |
Author
|
Yup makes sense. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just some better error handling on the back-end.