This repository was archived by the owner on Oct 8, 2021. It is now read-only.
Count-bubble positioning (part 2 of 2: select form)#4018
Closed
jaspermdegroot wants to merge 1 commit intojquery-archive:masterfrom
jaspermdegroot:patch-11
Closed
Count-bubble positioning (part 2 of 2: select form)#4018jaspermdegroot wants to merge 1 commit intojquery-archive:masterfrom jaspermdegroot:patch-11
jaspermdegroot wants to merge 1 commit intojquery-archive:masterfrom
jaspermdegroot:patch-11
Conversation
Contributor
Author
|
Replaced by PR #4154 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were no specific rules for count bubble positioning in select form button, so the same rules as used for listview buttons applied. Because there are differences between both (icon right positioning for example) I added those. Besides this I added rules for ui-select mini button with count bubble.
The rules are based on 45px (extra) padding-right if there is a count bubble and 10px space between the count bubble and the border or icon. For fullsize buttons as well as mini buttons.
The most generic rule for ui-li-count is still in the listview file for which I send a pull request as well (part 1 of 2). The changes I propose in this PR depend on the other. Together this is a fix for issue #3979.