Docs: Adding data-icon="false" for listview-items (attribute reference)#4161
Docs: Adding data-icon="false" for listview-items (attribute reference)#4161toddparker merged 1 commit intojquery-archive:masterfrom MauriceG:patch-65
Conversation
|
When data-icon is set to false the listview item still has the default data-iconpos right and class ui-btn--icon-right is added which means padding right. [Update: removed reference to other issue] |
|
Hi Maurice! No you've not got me wrong. You are right :-) The data attribute and the ui-btn-icon-right class is there (on the LI element) but listview items don't use this class at all. Only ui-li-has-arrow and that class is not added when you use data icon false. Good luck with all the good work on the documents! |
Docs: Adding data-icon="false" for listview-items (attribute reference) [1.1.1]
|
Cool that this works. @MauriceG - mind adding an example of various icons applied to listviews from your fiddle to this page: http://jquerymobile.com/test/docs/lists/docs-lists.html Maybe inside the thumbnail & icon section, after the 2 buttons. Add a sentence saying you can set the icon for any list with linked items and paste in those samples. |
|
@toddparker |
|
If you want I can help you with this. When you post introduction text in a comment here I will take care of the rest. |
|
Hi Jasper! |
|
Yeah I was just thinking about how to avoid confusion about 'icons'. In the navmenu the 'Lists with icon images' are simply called 'Icons' so that should change as well. Lets hear what Todd thinks is best. Please help to remind me I update the nav.html file (the search index) as well. |
|
Hi Everyone, The icons as per @MauriceG jsfiddle are covered on the list theming page: http://jquerymobile.com/test/docs/lists/lists-themes.html How about simply adding a heading "customizing lists" towards the end of http://jquerymobile.com/test/docs/lists/docs-lists.html, after inset lists that points to http://jquerymobile.com/test/docs/lists/lists-themes.html ? Anne |
|
Hi Anne :-) Okay, this would be another way. Or we just extend the listview at http://jquerymobile.com/test/docs/lists/lists-themes.html under Theming icons to show all icons. May we wait until @toddparker tell us, what he'd prefer. Maurice |
|
Hi Maurice :-) Yes, let's wait and see.... Anne |
|
Hi Anne and Maurice, Sounds like a good solution to refer to 'list theming'. Good night Europe! Jasper |
|
good night Netherlands ! :-). see us |
Docs: Adding data-icon="false" for listview-items (attribute reference) [1.1.1]
|
Hi all - Great ideas all around. I think adding a full set of icons to the section on theming will add soem nice emphasis (http://jquerymobile.com/test/docs/lists/lists-themes.html) and adding a link to this from the basics page as @agcolom suggests is also a good idea. Tweaking the language on the 3 buttons on the basics page to say "custom icons" or "16x16 icons" vs. "standard icons" will help distinguish these. I think that's the only place where there would be confusion between these types of icons but if you all see another place where this is confusing, let's use consistent language. |
Tested at http://jsfiddle.net/MauriceG/u2C76/