This repository was archived by the owner on Oct 8, 2021. It is now read-only.
jQuery Tag Inserter: added check for jQuery existence in conditional tha... #4997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that creates jQuery AMD definition. Fixes jquery-archive#4996. Win Phone 7/8: Slider onChange test failing.
gseguin
added a commit
that referenced
this pull request
Oct 15, 2012
jQuery Tag Inserter: added check for jQuery existence in conditional tha...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...t creates jQuery AMD definition. Fixes #4996. Win Phone 7/8: Slider onChange test failing.
WP 7 & 8 seem to have problems with jquery.tag.inserter.js. It seems that jQuery is not loaded in time for the conditional that creates the AMD definition. In WP, this conditional was always evaluating to true and causing the definition to run which, in turn, caused some strange event-related issue in the slider test. It may have been causing issues elsewhere, also. Will do more testing to see.
The drawback here is that AMD definition will probably never be loaded in WP. Based on the current logic, that seems like it will only be a problem when testing against jQuery versions < 1.7.0. I believe that leaves jQ 1.6.4 as the only supported version that will not run correctly.
Perhaps there is a better way to solve this problem to guarantee that all loading happens correctly, but it doesn't seem to happen in desktop browsers.