This repository was archived by the owner on Oct 8, 2021. It is now read-only.
inputs: add !important to resolve issue in build process #5175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SS overrides :-moz-placeholder setting later on. Fixes #5166 - Text input placeholder text not grayed out in Firefox
|
The other option for this would be to move the :-moz-placeholder line into the theme CSS instead, or to move the inclusion of css/structure/jquery.mobile.forms.textinput.css file to the end of the build structure build process. |
…t override. Fixes #5166 - Text input placeholder text not grayed out in Firefox
|
wilto advised using input:moz-placeholder instead of :moz-placeholder which avoids having to use !important and still corrects the issue in Firefox. |
Wilto
added a commit
that referenced
this pull request
Oct 15, 2012
inputs: add !important to resolve issue in build process
|
Good work, man! |
Wilto
added a commit
that referenced
this pull request
Oct 16, 2012
inputs: add !important to resolve issue in build process
Wilto
added a commit
that referenced
this pull request
Oct 16, 2012
inputs: add !important to resolve issue in build process
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inputs: add !important to resolve issue in build process where other CSS overrides :-moz-placeholder setting later on. Fixes #5166 - Text input placeholder text not grayed out in Firefox
Prior commit did not work properly after running through grunt build of CSS. Discussed with Jasper de Groot and we decided adding !important in this case is the best solution.