This repository was archived by the owner on Oct 8, 2021. It is now read-only.
Issue 1383 - fixes to handle single & double quotes in data-url #5435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests run against the unmodified code to verify the fixes made in the next commit
Use a direct reference since the variable isn't used for anything else
|
@SixtoSaez, Thank you for the pull request! It seems like you haven't signed a CLA. Please visit http://contribute.jquery.org/CLA/ and sign it so we can look into your PR. Thank you. |
|
Sorry about that, I must have missed that in the PR instructions. I just signed the CLA. Thanks for the reply & consideration! |
|
There are merge conflicts here if you would like to update pr ill be happy to look at it until then closing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my comment to this issue (#1383), there's a sample page that reproduces this issue.
In this branch, I first committed new unit tests that fail against against the current navigation code. Next I committed a couple of changes needed to handle these quote characters. I've only tested the fixes in Chrome & FireFox. Please let me know if you have any questions about the changes or the use case. Thanks for the consideration!