This repository was archived by the owner on Oct 8, 2021. It is now read-only.
Flatten custom select #6108
Merged
Flatten custom select #6108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
June 18, 2013 21:35
…Id" is used everywhere.
…ng o = this.options instead.
…dget to the button into the widget prototype and calling it _handleSelectFocus().
…rototype and calling it _handleButtonVclickKeydown().
…dget prototype and calling it _handleListFocus().
… a selector, use the "data-option-index" attribute that was set during list creation. This attribute was being set but it was not being used.
…oyed into the widget prototype and calling it _handleMenuPageHide().
…ing it via this._on().
…onto the header's close button into the widget prototype and calling it _handleHeaderCloseClick().
…effect, removing.
…alling it _focusMenuItem().
gabrielschulhof
pushed a commit
that referenced
this pull request
Jun 21, 2013
Flatten custom select
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move some methods out into the widget prototype. One method is kind of hard to move because it makes use of the /this/ parameter, which would become the widget itself were it to be moved out.
There are also some methods attached with .one() for which the widget factory provides no this._one() equivalent.