This repository was archived by the owner on Oct 8, 2021. It is now read-only.
jquery.mobile.tabele.reflow.js: removed the display: table-row-group; css. Fixes 6583. This display property causes assistive technology like VoiceOver to no longer detect the table as a table. #6584
Closed
dylanb wants to merge 1 commit intojquery-archive:masterfrom
Conversation
…tive technology not being able to detect tables
Contributor
|
i think we are good to land this |
Contributor
|
Let's pull it in a branch and test #5380 (comment) |
Contributor
|
👍 |
gabrielschulhof
pushed a commit
that referenced
this pull request
May 30, 2014
Contributor
Author
|
Is this problem totally fixed now or are you still looking for a solution for reflowable tables that are accessible? I have two solutions one that I have tried before and one that is ore elegant that I have not fully tested but if you are looking for a solution, I could try to test and implement. |
agcolom
pushed a commit
to agcolom/jquery-mobile
that referenced
this pull request
Nov 26, 2014
It causes problems with assistive technology not being able to detect tables. This effectively reverts bafa5d9, thus removing the fix for jquery-archivegh-5380. Closes jquery-archivegh-6584 Fixes jquery-archivegh-6583 Re jquery-archivegh-5380
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I apologize in advance for this pull request because I do not have Safari <= 5 and am therefore not able to reproduce bug 5380 - which this code was supposed to fix. However, the fix for 5380 is invalid because it directly causes the issue reported in 6583 in a lot of different browser and AT combinations.