Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

CONTRIBUTING.md update #6896

Closed
wants to merge 5 commits into from
Closed

CONTRIBUTING.md update #6896

wants to merge 5 commits into from

Conversation

jaspermdegroot
Copy link
Contributor

For review

@arschmitz
Copy link
Contributor

looks good to go 👍

@jaspermdegroot
Copy link
Contributor Author

Thanks @arschmitz. Actually I am going to add another commit for #6983 and squash them before merging.

@jaspermdegroot
Copy link
Contributor Author

Ready to be reviewed. Commits will be squashed and message from the second commit will be used.

@scottgonzalez
Copy link
Contributor

We have a standard contributing guideline that we use for all of our projects. Our larger projects tend to have more information, but there's a push to at least normalize the common stuff. Please take a look at https://github.com/jquery/jquery-color/blob/master/CONTRIBUTING.md which has the standard template and https://github.com/jquery/jquery-ui/blob/master/CONTRIBUTING.md which builds on the standard template.

@jaspermdegroot
Copy link
Contributor Author

@scottgonzalez @agcolom - Can you review this PR (again)? Thanks!

@agcolom
Copy link
Contributor

agcolom commented Feb 24, 2014

@uGoMobi I'm done. Would be happy for @scottgonzalez to also take a look.

@scottgonzalez
Copy link
Contributor

The consistency issue has been addressed. Thanks.

@jaspermdegroot
Copy link
Contributor Author

@agcolom - Can you do the final check and give it the thumbs up when it is good to go? I'll squash the commits before merging. Thanks!

@agcolom
Copy link
Contributor

agcolom commented Feb 24, 2014

👍

@jaspermdegroot
Copy link
Contributor Author

Landed in ecc9fa2

@jaspermdegroot jaspermdegroot deleted the contributing branch February 24, 2014 22:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants