-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Conversation
looks good to go 👍 |
Thanks @arschmitz. Actually I am going to add another commit for #6983 and squash them before merging. |
Ready to be reviewed. Commits will be squashed and message from the second commit will be used. |
We have a standard contributing guideline that we use for all of our projects. Our larger projects tend to have more information, but there's a push to at least normalize the common stuff. Please take a look at https://github.com/jquery/jquery-color/blob/master/CONTRIBUTING.md which has the standard template and https://github.com/jquery/jquery-ui/blob/master/CONTRIBUTING.md which builds on the standard template. |
@scottgonzalez @agcolom - Can you review this PR (again)? Thanks! |
@uGoMobi I'm done. Would be happy for @scottgonzalez to also take a look. |
The consistency issue has been addressed. Thanks. |
@agcolom - Can you do the final check and give it the thumbs up when it is good to go? I'll squash the commits before merging. Thanks! |
👍 |
Landed in ecc9fa2 |
For review