-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Page container: the load method now correctly returns a promise #6901
Page container: the load method now correctly returns a promise #6901
Conversation
…the docs. Fixed jquery-archive#6900. pagecontainer("load") does not return promise
@mk747gx it looks like you have not signed our cla can you please sign the CLA at http://contribute.jquery.org/CLA/ you will also find other useful information about contributing in general at http://contribute.jquery.org/ Let us know once you have signed and and then we can take a look at this. |
@arschmitz I signed the CLA as requested |
This fix looks good just one last thing is the commit message needs to be updated to our new commit message guidelines http://contribute.jquery.org/commits-and-pull-requests/#commit-guidelines |
I changed the commit message. Hopefully it now fulfills the commit guidelines (if not just tell me what I missed). I initially followed CONTRIBUTING.md which seems to have different rules than the link you provided. So maybe CONTRIBUTING.md needs an update. |
@mk747gx I'm in the middle of updating CONTRIBUTING.md for all projects. This will be fixed within a few days. Sorry for the confusion. |
@mk747gx can you please change your git config to have your real name and email matching what you signed the CLA with after that i can take a look at getting this merged |
…y-archive#6901 The API docs for version 1.4.0 state that the load method of the pagecontainer widget returns a promise. This commit adds this behaviour to the widget to comply with the docs Fixes jquery-archive#6900
… pagecontainer_load_returns_promise
…om/mk747gx/jquery-mobile into pagecontainer_load_returns_promise
@arschmitz should be fixed now |
The API docs for version 1.4.0 state that the load method of the pagecontainer widget returns a promise. This commit adds this behaviour to the widget to comply with the docs
Fixes #6900