Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

Page container: the load method now correctly returns a promise #6901

Conversation

marcuskrahl
Copy link
Contributor

The API docs for version 1.4.0 state that the load method of the pagecontainer widget returns a promise. This commit adds this behaviour to the widget to comply with the docs

Fixes #6900

…the docs. Fixed jquery-archive#6900. pagecontainer("load") does not return promise
@arschmitz
Copy link
Contributor

@mk747gx it looks like you have not signed our cla can you please sign the CLA at http://contribute.jquery.org/CLA/ you will also find other useful information about contributing in general at http://contribute.jquery.org/ Let us know once you have signed and and then we can take a look at this.

@marcuskrahl
Copy link
Contributor Author

@arschmitz I signed the CLA as requested

@arschmitz
Copy link
Contributor

This fix looks good just one last thing is the commit message needs to be updated to our new commit message guidelines http://contribute.jquery.org/commits-and-pull-requests/#commit-guidelines

@marcuskrahl
Copy link
Contributor Author

I changed the commit message. Hopefully it now fulfills the commit guidelines (if not just tell me what I missed). I initially followed CONTRIBUTING.md which seems to have different rules than the link you provided. So maybe CONTRIBUTING.md needs an update.

@scottgonzalez
Copy link
Contributor

@mk747gx I'm in the middle of updating CONTRIBUTING.md for all projects. This will be fixed within a few days. Sorry for the confusion.

@arschmitz
Copy link
Contributor

@mk747gx can you please change your git config to have your real name and email matching what you signed the CLA with after that i can take a look at getting this merged

…y-archive#6901

The API docs for version 1.4.0 state that the load method of the pagecontainer widget returns a promise. This commit adds this behaviour to the widget to comply with the docs

Fixes jquery-archive#6900
@marcuskrahl
Copy link
Contributor Author

@arschmitz should be fixed now

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0%) when pulling 1039f02 on mk747gx:pagecontainer_load_returns_promise into 1dc34cc on jquery:master.

@gabrielschulhof gabrielschulhof modified the milestones: 1.4.3, 1.4.1 Feb 28, 2014
gabrielschulhof pushed a commit that referenced this pull request Mar 11, 2014
The API docs for version 1.4.0 state that the load method of the pagecontainer
widget returns a promise. This commit adds this behaviour to the widget to
comply with the docs.

Closes gh-6901
Fixes gh-6900
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pagecontainer("load") does not return promise
5 participants