-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Demos: fix style on listview-linkbar demo #7101
Conversation
Thank you for noticing this issue and submitting a PR, however you are also changing the font size which was correct. While I admit the font size may be small on desktop, anything larger will not fit on a mobile screen. We should probably use a media query here to adjust based on screen size. However we don't want to change to 14px here. If you would like to either change this back to 8 or try adding a media query the selector change looks good. |
You're right. You're not being difficult. I think good demos are important. You're right about the text size, I should have tested it in the emulator first. This demo as a whole is pretty messed up on iOS 7 safari. Once you scroll the sorter is floating in the middle of the page. Perhaps that means I need to do some more work on it. |
I actually noticed this while looking at your PR. There was a library change that was preventing the height adjustment I'm fixing this already so don't worry about that. One thing to note about use of this on iOS though. iOS prevents javascript execution while scrolling. So ( once i push the fix ) the height adjustment will only take place once you stop scrolling and not during scrolling like in chrome or similar on desktop. |
Ok, I'll set the font back to 8px. |
@soberstadt Feel free to implement a media query if you feeling ambitious. :) |
After you fix the viewport height issues, i might clean it up some. |
Good to merge? |
Yes it looks good. I'm going to add this commit to some others to fix other issues with this demo. Ill push all fixes for the demo soon. |
This has been applied. |
No description provided.