Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

Listview: add support for enhanced option#7162

Closed
frequent wants to merge 1 commit intojquery-archive:masterfrom
frequent:pre-enhance-listview
Closed

Listview: add support for enhanced option#7162
frequent wants to merge 1 commit intojquery-archive:masterfrom
frequent:pre-enhance-listview

Conversation

@frequent
Copy link
Contributor

Fixes: gh-7161

@frequent
Copy link
Contributor Author

@uGoMobi:
I did not find a lot of tests on the pre-enhanced option. Let me know, if I should add more tests (and what should be tested...).

@jaspermdegroot
Copy link
Contributor

@frequent

Yeah, we should add those. @gabrielschulhof is now working on pre-rendered tests for table.

@arschmitz
Copy link
Contributor

@gabrielschulhof can you look at this and pull this into your classes changes for listview

@gabrielschulhof gabrielschulhof self-assigned this Jan 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The enhanced option cannot play a role in refresh(), because then subsequent calls to refresh() won't update the list. The correct way to handle the enhanced option is for _create() to not call refresh() if enhanced is true.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we could do

if ( create && o.enhanced ) {
  return;
}

gabrielschulhof pushed a commit to gabrielschulhof/jquery-mobile that referenced this pull request Jan 25, 2015
gabrielschulhof pushed a commit to gabrielschulhof/jquery-mobile that referenced this pull request Jan 31, 2015
gabrielschulhof pushed a commit to gabrielschulhof/jquery-mobile that referenced this pull request Feb 14, 2015
gabrielschulhof pushed a commit to gabrielschulhof/jquery-mobile that referenced this pull request Feb 18, 2015
gabrielschulhof pushed a commit to gabrielschulhof/jquery-mobile that referenced this pull request Apr 23, 2015
gabrielschulhof pushed a commit to gabrielschulhof/jquery-mobile that referenced this pull request May 2, 2015
gabrielschulhof pushed a commit to gabrielschulhof/jquery-mobile that referenced this pull request Jul 9, 2015
gabrielschulhof pushed a commit to gabrielschulhof/jquery-mobile that referenced this pull request Jul 9, 2015
gabrielschulhof pushed a commit to gabrielschulhof/jquery-mobile that referenced this pull request Jul 14, 2015
gabrielschulhof pushed a commit to gabrielschulhof/jquery-mobile that referenced this pull request Jul 15, 2015
gabrielschulhof pushed a commit to gabrielschulhof/jquery-mobile that referenced this pull request Jul 16, 2015
@arschmitz
Copy link
Contributor

This was combined with @gabrielschulhof PR closing

@arschmitz arschmitz closed this Jul 30, 2015
gabrielschulhof pushed a commit to gabrielschulhof/jquery-mobile that referenced this pull request Aug 4, 2015
gabrielschulhof pushed a commit to gabrielschulhof/jquery-mobile that referenced this pull request Aug 13, 2015
gabrielschulhof pushed a commit to gabrielschulhof/jquery-mobile that referenced this pull request Aug 28, 2015
arschmitz pushed a commit to arschmitz/jquery-mobile that referenced this pull request Jul 4, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Listview: Missing support for data-enhanced

4 participants