Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

Listview performance improvements #7228

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions js/widgets/addFirstLastClasses.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,31 @@ define( [ "jquery", "../core" ], function( jQuery ) {
//>>excludeEnd("jqmBuildExclude");
(function( $, undefined ) {

var uiScreenHiddenRegex = /\bui-screen-hidden\b/;
function noHiddenClass( elements ) {
var index,
length = elements.length,
result = [];

for ( index = 0; index < length; index++ ) {
if ( !elements[ index ].className.match( uiScreenHiddenRegex ) ) {
result.push( elements[ index ] );
}
}

return $( result );
}

$.mobile.behaviors.addFirstLastClasses = {
_getVisibles: function( $els, create ) {
var visibles;

if ( create ) {
visibles = $els.not( ".ui-screen-hidden" );
visibles = noHiddenClass( $els );
} else {
visibles = $els.filter( ":visible" );
if ( visibles.length === 0 ) {
visibles = $els.not( ".ui-screen-hidden" );
visibles = noHiddenClass( $els );
}
}

Expand Down
6 changes: 5 additions & 1 deletion js/widgets/listview.js
Original file line number Diff line number Diff line change
Expand Up @@ -145,11 +145,15 @@ $.widget( "mobile.listview", $.extend( {
.attr( "title", $.trim( last.getEncodedText() ) )
.addClass( altButtonClass )
.empty();

// Reduce to the first anchor, because only the first gets the buttonClass
a = a.first();
} else if ( icon ) {
buttonClass += " ui-btn-icon-right ui-icon-" + icon;
}

a.first().addClass( buttonClass );
// Apply buttonClass to the (first) anchor
a.addClass( buttonClass );
} else if ( isDivider ) {
dividerTheme = ( getAttr( item[ 0 ], "theme" ) || o.dividerTheme || o.theme );

Expand Down