This repository was archived by the owner on Oct 8, 2021. It is now read-only.
Panel: Bail upon opening animationComplete() if the panel has closed #7264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 24, 2014 09:13
Originally, .panel( "close" ) was called synchronously with .panel( "open" ), while asynchronous assertions were being made in handlers for both panelopen and panelclose. This doesn't work anymoure, because panelopen is not triggered if .panel( "close" ) is called before panelopen is fired.
|
👍 |
gabrielschulhof
pushed a commit
that referenced
this pull request
Apr 24, 2014
Hook up animationComplete() to the wrapper, if present, and only otherwise to the element, because the animation class is only added to the element if there is no wrapper. The tests now need to wait for the panel to actually open in order to hit all the assertions, because some assertions are made only upon panelopen. (cherry picked from commit 301f124) Closes gh-7264 Fixes gh-7236
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Panel: Hook up animationComplete() to the wrapper, not the element
Panel: Bail upon opening animationComplete() if the panel has closed
Fixes gh-7236