Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

Page events demo and pagecontainer updates #7285

Closed
wants to merge 3 commits into from
Closed

Page events demo and pagecontainer updates #7285

wants to merge 3 commits into from

Conversation

arschmitz
Copy link
Contributor

This is demo of page events using the event debugger.
Also included to this is updates to page container based on our decision to unify params and events in pagecontainer.

@gabrielschulhof
Copy link

@arschmitz After this has landed, we need to update demos/selectmenu-custom-filter/index.php to no longer rely on pagebeforeshow and pagehide. Until then, the deprecated events cannot be replaced, because during pagecontainerhide, I have no way of knowing which page is being hidden: $.mobile.activePage points to the new page, and data only has nextPage.

@gabrielschulhof gabrielschulhof mentioned this pull request May 13, 2014
Closed
@coveralls
Copy link

Coverage Status

Coverage increased (+0.16%) when pulling 303438a on page-events-demo into 8197bb0 on master.

arschmitz
arschmitz reviewed May 22, 2014
View reviewed changes
js/widgets/pagecontainer.js
@@ -788,14 +803,14 @@ define( [

promise = ( new TransitionHandler( transition, reverse, to, from ) ).transition();

promise.done($.proxy(function() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spacing

@jaspermdegroot jaspermdegroot added this to the 1.4.3 milestone Jun 5, 2014
@gabrielschulhof
Copy link

You get the following exception from demos/page-events/alertevents.php when you attempt to open the popup: Uncaught TypeError: Converting circular structure to JSON

@gabrielschulhof
Copy link

arschmitz/jquery-mobile-event-debugger#3

@coveralls
Copy link

Coverage Status

Coverage decreased (-8.21%) when pulling 7aef437 on page-events-demo into 8197bb0 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-8.35%) when pulling 7aef437 on page-events-demo into 8197bb0 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-8.21%) when pulling 733a2fe on page-events-demo into 8197bb0 on master.

@arschmitz
Copy link
Contributor Author

@gabrielschulhof this failure is legit

@arschmitz arschmitz changed the title Page events demo: Not for review testing only Page events demo and pagecontainer updates Jun 14, 2014
@gabrielschulhof
Copy link

Checking it out ...

@gabrielschulhof
Copy link

OK ... I need to expect the file URL.

@gabrielschulhof
Copy link

I haven't tested this with ?jquery=1.8.3 and such.

@gabrielschulhof
Copy link

OK. This is weird. It's passing locally.

arschmitz added a commit that referenced this pull request Jun 16, 2014
@arschmitz
Pagecontainer: make all page events go through triggerWithDeprecated
534e9fe 
To make sure all former page events have a page container counterpart,
and that this counterpart has both a toPage and prevPage prop on the ui
object
Also add a demo of how to debug pagecontainer events

Fixes gh-7063
Fixes gh-70283
Fixes gh-7176
Closes gh-7285
@coveralls
Copy link

Coverage Status

Coverage increased (+0.29%) when pulling 534e9fe on page-events-demo into 373ddae on master.

@arschmitz
Pagecontainer: make all page events go through triggerWithDeprecated
5319adc 
To make sure all former page events have a page container counterpart,
and that this counterpart has both a toPage and prevPage prop on the ui
object
Also add a demo of how to debug pagecontainer events

Fixes gh-7063
Fixes gh-7283
Fixes gh-7176
Closes gh-7285
@coveralls
Copy link

Coverage Status

Coverage increased (+0.22%) when pulling 5319adc on page-events-demo into 373ddae on master.

arschmitz
arschmitz reviewed Jun 18, 2014
View reviewed changes
tests/integration/pagecontainer/page_event_sequence_core.js
"pagecontainerloadfailed",
"pagebeforecreate",
"pagecreate",
"pageinit",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is deprecated in 1.4.0

@arschmitz arschmitz closed this in 3d4d7dd Jun 18, 2014
gabrielschulhof pushed a commit that referenced this pull request Jun 18, 2014
@arschmitz
Selectmenu: Update demo to no longer rely on deprecated page events
18d6b12 
Re #7285 (comment)
@coveralls
Copy link

Coverage Status

Coverage increased (+0.17%) when pulling 5919875 on page-events-demo into 373ddae on master.

arschmitz added a commit that referenced this pull request Jun 18, 2014
@arschmitz
Pagecontainer: make all page events go through triggerWithDeprecated
40b626e 
To make sure all former page events have a page container counterpart,
and that this counterpart has both a toPage and prevPage prop on the ui
object
Also add a demo of how to debug pagecontainer events

Fixes gh-7063
Fixes gh-7283
Fixes gh-7176
Closes gh-7285

(cherry picked from commit 3d4d7dd)
gabrielschulhof pushed a commit that referenced this pull request Jun 18, 2014
@arschmitz
Selectmenu: Update demo to no longer rely on deprecated page events
9b0882c 
Re #7285 (comment)

(cherry picked from commit 18d6b12)
@arschmitz arschmitz deleted the page-events-demo branch July 1, 2014 16:35
agcolom pushed a commit to agcolom/jquery-mobile that referenced this pull request Nov 26, 2014
@arschmitz @agcolom
Pagecontainer: make all page events go through triggerWithDeprecated
d76c5c9 
To make sure all former page events have a page container counterpart,
and that this counterpart has both a toPage and prevPage prop on the ui
object
Also add a demo of how to debug pagecontainer events

Fixes jquery-archivegh-7063
Fixes jquery-archivegh-7283
Fixes jquery-archivegh-7176
Closes jquery-archivegh-7285
agcolom pushed a commit to agcolom/jquery-mobile that referenced this pull request Nov 26, 2014
@agcolom
Selectmenu: Update demo to no longer rely on deprecated page events
9fc160a 
Re jquery-archive#7285 (comment)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Tag: Page(container) events
Projects
None yet
Milestone
1.4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@arschmitz @gabrielschulhof @coveralls @jaspermdegroot