IE 10 moving to background. #7298
Conversation
In IE 10 (and possibly older versions of IE) when there is a single tab open and a popup is displayed and there is another window on the same monitor, calling target.blur() can cause the browser to go to the background because the body element is the targetElement. Ensuring the element is not the body element before calling blur() fixes this issue.
In IE 10 (and possibly older versions of IE) when there is a single tab open and a popup is displayed and there is another window on the same monitor, calling target.blur() can cause the browser to go to the background because the body element is the targetElement. Ensuring the element is not the body element before calling blur() fixes this issue.
|
@TrueEddie thank you for submitting this PR can you please take a moment and sign our CLA http://contribute.jquery.org/CLA/ then we will be happy to take a look at this. |
|
Done ;) |
| @@ -288,7 +288,10 @@ $.widget( "mobile.popup", { | |||
| target = $( targetElement ); | |||
| if ( 0 === target.parents().filter( ui.container[ 0 ] ).length ) { | |||
| $( this.document[ 0 ].activeElement ).one( "focus", function(/* theEvent */) { | |||
| target.blur(); | |||
| if (targetElement.nodeName.toLowerCase() !== "body") | |||
There was a problem hiding this comment.
You need spaces after the opening and before the closing parens .
|
@thanks for taking the time to contribute to jQuery Mobile. We have the following requirements of pull requests before we can review them.
If you are interested in continuing with this change, please update this pull request accordingly |
Fixed spacing to fit with guidelines.
|
@arschmitz, thanks for helping me with this pull request. I must admit I'm new to GitHub and open source contribution. I added my name to my profile which hopefully is what you meant by step 1. Step 2: Where do I go to make a ticket? Is that different then an issue? Again, thanks for your help. |
|
@TrueEddie no a ticket is an issue they are the same thing just open one explain the issue and include a reduced test case. and then reference this issue in it. If you have any other questions just let me know |
|
@TrueEddie just checking if you still plan on pursuing this PR? |
In IE 10 (and possibly older versions of IE) when there is a single tab open and a popup is displayed and there is another window on the same monitor, calling target.blur() can cause the browser to go to the background because the body element is the targetElement. Ensuring the element is not the body element before calling blur() fixes this issue. Fixes gh-7639 Closes gh-7298 (cherry picked from commit b14dd31)
In IE 10 (and possibly older versions of IE) when there is a single tab open and a popup is displayed and there is another window on the same monitor, calling target.blur() can cause the browser to go to the background because the body element is the targetElement. Ensuring the element is not the body element before calling blur() fixes this issue. Fixes jquery-archivegh-7639 Closes jquery-archivegh-7298
In IE 10 (and possibly older versions of IE) when there is a single tab open and a popup is displayed and there is another window on the same monitor, calling target.blur() can cause the browser to go to the background because the body element is the targetElement. Ensuring the element is not the body element before calling blur() fixes this issue.