Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

Navigation: Add demo showing how to copy script references and widgets #7370

Closed
wants to merge 24 commits into from
Closed

Navigation: Add demo showing how to copy script references and widgets #7370

wants to merge 24 commits into from

Conversation

gabrielschulhof
Copy link

Fixes gh-7362

@gabrielschulhof gabrielschulhof added this to the 1.4.3 milestone May 6, 2014
@gabrielschulhof
Copy link
Author

Here's the demo link from view: http://view.jquerymobile.com/7362-ajax-with-external-widgets-demo/demos/navigation-ajax-external-widgets/

This was referenced May 6, 2014
Closed
Closed
@jaspermdegroot
Copy link
Contributor

@gabrielschulhof

This looks good to me. I would only move the menu button to the left and use a text button with "navigate" in it.

@arschmitz can you give the demo a look as well?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) when pulling af847a1 on 7362-ajax-with-external-widgets-demo into 39fe09e on master.

@arschmitz
Copy link
Contributor

@gabrielschulhof you should look at the the optimized toolbar demos and these should be combined or at least reference each other in some way http://demos.jquerymobile.com/1.4.2/toolbar-fixed-persistent-optimized/

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) when pulling 37d91ef on 7362-ajax-with-external-widgets-demo into 39fe09e on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) when pulling e06db6d on 7362-ajax-with-external-widgets-demo into 39fe09e on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) when pulling 55ce9a9 on 7362-ajax-with-external-widgets-demo into 39fe09e on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) when pulling 55ce9a9 on 7362-ajax-with-external-widgets-demo into 39fe09e on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) when pulling 55ce9a9 on 7362-ajax-with-external-widgets-demo into 39fe09e on master.

@jaspermdegroot jaspermdegroot modified the milestones: 1.4.4, 1.4.3 Jun 12, 2014
@arschmitz
Copy link
Contributor

@gabrielschulhof is this ready to review again?

@gabrielschulhof
Copy link
Author

@arschmitz no, not yet.

@arschmitz arschmitz mentioned this pull request Sep 4, 2014
Closed
@gabrielschulhof gabrielschulhof force-pushed the 7362-ajax-with-external-widgets-demo branch from 55ce9a9 to 89916b7 Compare September 9, 2014 07:11
Gabriel Schulhof added 14 commits December 29, 2014 15:38
Toolbar: Elaborating on the need for copying shared stuff
0e065b0
View source: Append popup to body to work with external widgets
9aa88ba
Navigation: Adding blurb about optimizing server-side
035afe8
Toolbar: Typo in shared init script
b9ba097
Toolbar: Add <head> to markup in view source and explanatory blurb
15cd84a
Toolbar: activate navbar links upon navigation
d39fbe5 
Fixes gh-7087
Demos: Re-purpose fixed persistent optimized toolbar demo
41a67fe 
Turn it into a generic demo showing external widgets.
Demos: Updating links from toolbar and popup to external widgets demo
8521138
Demos: Adding panel to external widgets demo
2e35174
Demos: Add internal panel to external widgets demo
e94026e
Demos: Point external panel links to external widget demo
1dd72fe
Panel: Point external panel demo link to external widgets demo
3220989
Demos: Move external widgets demo panel content to popup and vice versa
de1b61c
View source: Delegate popup-related events from document
c0bd693 
We have to do this because the popup now attaches to the body
@gabrielschulhof gabrielschulhof force-pushed the 7362-ajax-with-external-widgets-demo branch from bbcffcd to bb24684 Compare December 29, 2014 16:50
@gabrielschulhof gabrielschulhof force-pushed the 7362-ajax-with-external-widgets-demo branch from bb24684 to 664f79d Compare December 29, 2014 17:27
@arschmitz
Copy link
Contributor

@gabrielschulhof Is this PR ready to review again?

@gabrielschulhof
Copy link
Author

@arschmitz Yes it is, absolutely.

@arschmitz
Copy link
Contributor

👍

@gabrielschulhof gabrielschulhof deleted the 7362-ajax-with-external-widgets-demo branch June 4, 2015 18:59
kapilgarg1996 pushed a commit to kapilgarg1996/jquery-mobile that referenced this pull request Jun 27, 2015
@kapilgarg1996
Navigation: Add demo showing how to copy script references and widgets
8a534b5 
Fixes jquery-archivegh-7362
Fixes jquery-archivegh-7087
Closes jquery-archivegh-7370
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@gabrielschulhof gabrielschulhof

Labels
Component: Navigation Component: Panel Component: Popup Component: Toolbar Demos Tag: Fixed toolbars
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

Combine external toolbar, external panel, and external widget Ajax navigation demos
4 participants
@gabrielschulhof @jaspermdegroot @coveralls @arschmitz