This repository was archived by the owner on Oct 8, 2021. It is now read-only.
Selectmenu: Add demo sporting placeholder #7398
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before landing this I'll de-indent the demo code block by one tab, so don't worry about line lengths. With the de-indentation, they're all below 100 characters. I've checked. I didn't want to de-indent as part of the PR, because that makes the differences in the code a lot harder to decipher. |
|
I think a PR should always show what you intend to merge, no matter if it's harder to read or not. |
|
👍 (after fixing the indent and that typo, and squashing the commits) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-7396