Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

Selectmenu: Missing comma in variable declaration #7411

Merged
merged 1 commit into from
May 22, 2014

Conversation

gabrielschulhof
Copy link

Fixes gh-7405

@jaspermdegroot
Copy link
Contributor

👍

@gabrielschulhof gabrielschulhof merged commit 6220624 into master May 22, 2014
@gabrielschulhof gabrielschulhof deleted the 7405-more-filterable-selectmenu-demo-fixes branch May 22, 2014 09:31
@slavap
Copy link

slavap commented May 22, 2014

Not completely fixed :-)

.on( "pagebeforeshow", "#filter-menu-dialog,#title-filter-menu-dialog", function( event ) {
    var dialog = $( event.target )
    listview = dialog.find( "ul" ),
    form = listview.jqmData( "filter-form" );

must be

.on( "pagebeforeshow", "#filter-menu-dialog,#title-filter-menu-dialog", function( event ) {
    var dialog = $( event.target ),
    listview = dialog.find( "ul" ),
    form = listview.jqmData( "filter-form" );

It's time to switch to something more advanced than JavaScript - TypeScript or Dart :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Filterable inside custom select" demo fails on pressing ENTER in search field.
4 participants