Fieldcontain: Reset width for notext buttons #7525
Conversation
Buttons with .ui-btn-icon-notext normally have a fixed width of 1.75em. However when putting them as inline buttons inside a .ui-field-contain, from a certain page width on they get a width:auto, making them use the available width on the page instead of staying at a fixed width. This overrides the width:auto with the 1.75em again in that situation.
|
Sorry, I was a bit too fast in submitting this and didn't check the guidelines for pull requests. I will sign the CLA and submit a bug report as well. |
|
Submitted a ticket: #7526 |
|
And I've signed the CLA now. |
|
@Shepard - Thanks for the PR! I noticed you've signed the CLA with a different email address than you use in your git config. Can you please sign again using your Git config email address? Thanks! @arschmitz - I reviewed and tested this and we should land this change. It's an addition to 7c4eb00 where I added the width override for inline buttons. Just haven't thought of icon-only buttons at that time. |
|
Sorry for the delay, I signed the CLA with the other email address as well now. |
|
Yeah this looks good to me too we just need to make sure to rebase to fix the commit message when we land this 👍 |
Buttons with .ui-btn-icon-notext normally have a fixed width of 1.75em. However when putting them as inline buttons inside a .ui-field-contain, from a certain page width on they get a width:auto, making them use the available width on the page instead of staying at a fixed width. This overrides the width:auto with the 1.75em again in that situation. Fixes gh-7526 Closes gh-7525 (cherry picked from commit 2dd9cf4)
Buttons with .ui-btn-icon-notext normally have a fixed width of 1.75em. However when putting them as inline buttons inside a .ui-field-contain, from a certain page width on they get a width:auto, making them use the available width on the page instead of staying at a fixed width. This overrides the width:auto with the 1.75em again in that situation. Fixes jquery-archivegh-7526 Closes jquery-archivegh-7525
Buttons with .ui-btn-icon-notext normally have a fixed width of 1.75em.
However when putting them as inline buttons inside a .ui-field-contain, from a certain page width on they get a width:auto, making them use the available width on the page instead of staying at a fixed width.
This overrides the width:auto with the 1.75em again in that situation.