Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

Demos: persistent toolbar active state fix #7584

Closed

Conversation

cgack
Copy link
Contributor

@cgack cgack commented Jul 23, 2014

Fixes gh-7578

@arschmitz
Copy link
Contributor

This looks good to me works and all tests still pass the only thing is the component should be toolbar: not demos but we will just fix that when we rebase this to land it anyway 👍

@cgack
Copy link
Contributor Author

cgack commented Jul 25, 2014

I'm a little confused why this isn't Demos but i'm okay with calling it toolbar too. Should I rebase this or is that something you plan to do when its time to land it?

@arschmitz
Copy link
Contributor

@cgack We will do it when its ready to land so we don't destroy the pr history. The reason thats its toolbars not demos is because its a demo of toolbar. When possible always use the actual component name your working on as the component name in the commit message. The demos component name is only used if its something thats is not specific to another component. For example if you were to change the header in all the demos.

@arschmitz arschmitz closed this in 2637803 Aug 21, 2014
arschmitz pushed a commit that referenced this pull request Aug 26, 2014
agcolom pushed a commit to agcolom/jquery-mobile that referenced this pull request Nov 26, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

persistant toolbars ui-btn-active
2 participants