This repository was archived by the owner on Oct 8, 2021. It is now read-only.
Closed
Conversation
Fixes case where non-native multiple select is used and checkbox
is not un-checked when setting .prop(" selected ", false)
Closes jquery-archivegh-7732
|
@imaffett could you please add a test for this? |
Author
|
Sorry - this actually fails (it adds the checkbox). I never pushed up my second fix to my branch before the PR. Adding a test and the correct fix now. |
Real fix (before I was adding the class instead of removing) Add test case in tests/unit/select/select_core.js
Contributor
There was a problem hiding this comment.
Move this to the next line up on same line as closing curly brace
gabrielschulhof
pushed a commit
that referenced
this pull request
Oct 29, 2014
agcolom
pushed a commit
to agcolom/jquery-mobile
that referenced
this pull request
Nov 26, 2014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes case where non-native multiple select is used and checkbox
is not un-checked when setting .prop(" selected ", false)
Closes gh-7732