This repository was archived by the owner on Oct 8, 2021. It is now read-only.
Build: Improve custom build module ordering and CSS production#7892
Closed
gabrielschulhof wants to merge 3 commits intojquery-archive:masterfrom
Closed
Build: Improve custom build module ordering and CSS production#7892gabrielschulhof wants to merge 3 commits intojquery-archive:masterfrom
gabrielschulhof wants to merge 3 commits intojquery-archive:masterfrom
Conversation
794c57a to
32b870c
Compare
32b870c to
ba068aa
Compare
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Constructing a custom structure, theme, and combined CSS for a given value of the --modules command line parameter was missing. This PR implements that.
The order in which modules are specified on the command line is not necessarily correct. The order in which they are specified in js/jquery.mobile.js is correct. So far, js/jquery.mobile.js was being parsed using regular expressions to retrieve the list of modules as it appears in js/jquery.mobile.js. This PR improves upon that by retrieving the list from js/jquery.mobile.js by parsing the file using esprima.