Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

All: Make sure events are well-formed and offsets are valid #8135

Conversation

gabrielschulhof
Copy link

Fixes gh-8134

@arschmitz
Copy link
Contributor

Changes to offset should not be included here these are not final yet and are likely to be reverted.

@arschmitz
Copy link
Contributor

Other then removing the offset changes this looks good

@gabrielschulhof gabrielschulhof force-pushed the 8134-handle-core-induced-breakage branch from c6372a4 to 58aa55d Compare May 23, 2015 20:38
@gabrielschulhof
Copy link
Author

@arschmitz I've removed the offset stuff. It's all event-related now.

@arschmitz
Copy link
Contributor

This has TONS of failures on git still not sure if these are related or not have not looked yet. some are offset those can be ignored.

@gabrielschulhof
Copy link
Author

@arschmitz there's been some new breakage in core related to some variable named url being not a string and core unconditionally calling .indexOf() on it.

@arschmitz
Copy link
Contributor

ok lets go ahead and get this landed 👍

gabrielschulhof pushed a commit that referenced this pull request Jun 5, 2015
@gabrielschulhof gabrielschulhof deleted the 8134-handle-core-induced-breakage branch June 5, 2015 08:26
arschmitz pushed a commit to arschmitz/jquery-mobile that referenced this pull request Jun 9, 2015
gabrielschulhof pushed a commit that referenced this pull request Jun 9, 2015
arschmitz pushed a commit to arschmitz/jquery-mobile that referenced this pull request Jul 4, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants