This repository was archived by the owner on Oct 8, 2021. It is now read-only.
All: Make sure events are well-formed and offsets are valid #8135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes to offset should not be included here these are not final yet and are likely to be reverted. |
|
Other then removing the offset changes this looks good |
c6372a4 to
58aa55d
Compare
|
@arschmitz I've removed the offset stuff. It's all event-related now. |
|
This has TONS of failures on git still not sure if these are related or not have not looked yet. some are offset those can be ignored. |
|
@arschmitz there's been some new breakage in core related to some variable named |
|
ok lets go ahead and get this landed 👍 |
arschmitz
pushed a commit
to arschmitz/jquery-mobile
that referenced
this pull request
Jun 9, 2015
arschmitz
pushed a commit
to arschmitz/jquery-mobile
that referenced
this pull request
Jul 4, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-8134