-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Hide page with visibility #8241
Conversation
Also remove the animation during the initial create height setting
This looks good to me and the test failure has nothing to do with this change ... Update: I found an issue (will describe in new comment) so we can't merge yet |
This comment should be updated: https://github.com/jquery/jquery-mobile/blob/page-hide/js/transitions/transition.js#L118 (display block --> visibility: visible) |
When we hide the page with If you look at our transitions demo (http://view.jquerymobile.com/page-hide/demos/transitions/) on a wide screen you can see the problem that this can cause. We make the menu panel visible on wide screens with So we have to make sure that all content on the page becomes invisible. The only (ugly) way to do this is:
|
Also accounts for nested elements with visibility:visible Closes gh-8241
fixed and landed in 1.5-dev |
Avoiding display: none means we can calculate heights before transitions This means less visual update after the end of the transition and removes the need for binding to pageshow for page layout updates this also has a small performance benefit since it avoids reflows Closes jquery-archivegh-8241 Fixes jquery-archivegh-8137
Also accounts for nested elements with visibility:visible Closes jquery-archivegh-8241
This updates to use visibility to hide inactive pages. This has several advantages