This repository was archived by the owner on Oct 8, 2021. It is now read-only.
Listview: Fix refresh() #8489
Merged
Listview: Fix refresh() #8489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c98ea80 to
b6f2e66
Compare
gabrielschulhof
pushed a commit
to gabrielschulhof/jquery-mobile
that referenced
this pull request
Jul 28, 2016
b6f2e66 to
6804dba
Compare
gabrielschulhof
pushed a commit
to gabrielschulhof/jquery-mobile
that referenced
this pull request
Jul 29, 2016
1. Fix signature of public refresh() method
2. Move sparing _refresh() decision to backcompat
The decision is delegated to extension points (one for the list item and
one the anchor(s) it may contain) which are predicates that always return
true if the backcompat extension is absent, indicating for every item that
it is to be processed.
When the backcompat extension is present, the extension points contain the
class-examining regex-based decision of previous versions.
3. Add method updateItems()
In _refresh() we still need to retrieve all list items, even when we get a
list of items from updateItems(), because the followings require global
knowledge:
- Which items have been removed since last time, so we can untrack them
- Which is the first resp. last item for use with addFirstLastClasses()
Closes jquery-archivegh-8489
Fixes jquery-archivegh-8334
1. Fix signature of public refresh() method
2. Move sparing _refresh() decision to backcompat
The decision is delegated to extension points (one for the list item and
one the anchor(s) it may contain) which are predicates that always return
true if the backcompat extension is absent, indicating for every item that
it is to be processed.
When the backcompat extension is present, the extension points contain the
class-examining regex-based decision of previous versions.
3. Add method updateItems()
In _refresh() we still need to retrieve all list items, even when we get a
list of items from updateItems(), because the followings require global
knowledge:
- Which items have been removed since last time, so we can untrack them
- Which is the first resp. last item for use with addFirstLastClasses()
Closes jquery-archivegh-8489
Fixes jquery-archivegh-8334
6804dba to
e5b2562
Compare
gabrielschulhof
pushed a commit
that referenced
this pull request
Aug 11, 2016
1. Fix signature of public refresh() method
2. Move sparing _refresh() decision to backcompat
The decision is delegated to extension points (one for the list item and
one the anchor(s) it may contain) which are predicates that always return
true if the backcompat extension is absent, indicating for every item that
it is to be processed.
When the backcompat extension is present, the extension points contain the
class-examining regex-based decision of previous versions.
3. Add method updateItems()
In _refresh() we still need to retrieve all list items, even when we get a
list of items from updateItems(), because the followings require global
knowledge:
- Which items have been removed since last time, so we can untrack them
- Which is the first resp. last item for use with addFirstLastClasses()
Closes gh-8489
Fixes gh-8334
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updateItems()refresh()exhaustive