This repository was archived by the owner on Oct 8, 2021. It is now read-only.
Fixed issue in URL parsing#8650
Merged
apsdehal merged 3 commits intojquery-archive:masterfrom Jun 13, 2019
Merged
Conversation
Fixed "Broken URL parsing" issue mentioned in issue jquery-archive#8640 [details: 1) empty username or password are allowed, 2) colon in password is allowed]
To avoid incorrect parsing of URL like `http://evil.domain\@good.domain/
Contributor
Author
|
I've fixed urlParseRE regex to handle forward and back slashed identically. |
One slash has been missed
|
This is an security issue like mentioned before so we should merge this state which can be cherry-picked to older versions. ref: #8640 |
Contributor
|
@dryabov Thanks for all of the fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed "Broken URL parsing" issue mentioned in issue #8640 [details: 1) empty username or password are allowed, 2) colon in password is allowed]