-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Latest Chrome update breaks plugin response handling #571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I am also having the same problem. To elaborate on @webmasterlv post: to |
I Googled a little bit about this, and seems like about:blank is the best to be used. If the element has no src attribute specified, or its value is the empty string, let url be the URL "about:blank". There are major updates at the moment, and apparently Chrome does not like javascript:false anymore in the iframe source. |
Originally this always used |
I'm on 83.0.4103.61 on latest MacOS Catalina and cannot reproduce this. I've used the jsfiddle and both buttons work for me. |
@klonos both buttons will trigger an alert, but the difference lies in the actual network response. For me, prior to 83, both buttons result in a 404 response from jshell.net. But for 83, the default iframeSrc button request is canceled by the browser, whereas the default
|
(Edit: Oh, nevermind, just saw #572, which patches this and already accounts for IE) Just wanted to chime in and say that over in Drupal land, the Quick note is that |
same problem here using jquery 1.5 and jquery form for document upload
and document upload needed to be updated to : $("#ajaxUploadForm").ajaxForm({ not the best fix but works for now... |
I was linked to this issue from https://bugs.chromium.org/p/chromium/issues/detail?id=1086008 |
@josepharhar is this issue same as #573 ? |
Since that issue says that you must have an iframe with src=“javascript:false”, i think it is the same issue. |
@josepharhar Yes we have a iframe created by jquery.form plugin with src as javascript:false. I just can confirmed by modifying the plugin to change the javascript:false to about:blank and it worked. |
@josepharhar Please suggest me that I need to do upgrade the jquery plugin with the new version or the chrome developers will going to fix in the next release, if yes please suggest me how I need to handle this case for the time being. |
Patches jquery.form per advice on this issue: jquery-form/form#571 Ajax doesn't support posting files, so before FormData, the only way to upload a file without a page refresh was to create an iframe, build a form in it, and submit that to the server in a way where it could sync up with the data POSTed by ajax. Chrome 83 has an issue with the fake src jquery.form was setting on that iframe, and would cancel the request. With no image uploaded to the server (but no error in js to treat as a blocking error) the process would attempt to continue and hit an error when it tries to access a file that doesn't exist. FUN-2604
It will be fixed in chrome within the next three weeks |
Patches jquery.form per advice on this issue: jquery-form/form#571 Ajax doesn't support posting files, so before FormData, the only way to upload a file without a page refresh was to create an iframe, build a form in it, and submit that to the server in a way where it could sync up with the data POSTed by ajax. Chrome 83 has an issue with the fake src jquery.form was setting on that iframe, and would cancel the request. With no image uploaded to the server (but no error in js to treat as a blocking error) the process would attempt to continue and hit an error when it tries to access a file that doesn't exist. FUN-2604
@josepharhar Thank you so much for your update. |
Yep, I got an update to 83.0.4103.97 on my personal machine today which includes the fix, it is getting rolled out earlier than I originally planned. Check chrome://settings/help to see if you have the update! |
Latest Google Chrome update (v83.0.4103.97) appears to have solved this issue for me. i removed my previous post as i thought i was on the wrong thread - whoops! |
Fixed by #572 |
Description:
After the latest Chrome update (mine is 83.0.4103.61) the success callback is not called anymore if using
iframe:true
although the request gets to the server. Chrome dev tools shows request as cancelled.I managed to fix this by setting
iframeSrc:'about:blank'
.I cannot find a reason or implication of this change. But maybe iframeSrc default should be changed?
Expected Behavior:
Receive success callback with response from server.
Actual behavior:
Success callback is not called, request shows aborted in Chrome.
Versions:
LoadJSON:
jQuery: 3.4
Browsers: Chrome 83.0.4103.61
Demonstration
Demo here
Steps to reproduce:
Use default setting of
iframeSrc
The text was updated successfully, but these errors were encountered: