Skip to content

In fileUploadXhr: The beforeSend wrapper should return the wrapped return value #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AdelRefaat wants to merge 1 commit into from
Closed

In fileUploadXhr: The beforeSend wrapper should return the wrapped return value #426

AdelRefaat wants to merge 1 commit into from

Conversation

@AdelRefaat
Copy link

@AdelRefaat AdelRefaat commented Jul 17, 2014

In fileUploadXhr: The beforeSend wrapper should return the wrapped return value, or true if nothing is wrapped.

@AdelRefaat
Update jquery.form.js
5e0e4dd 
In fileUploadXhr: The beforeSend wrapper should return the wrapped return value, or true if nothing is wrapped.
@kevindb
Copy link
Member

kevindb commented Mar 6, 2017 •
edited
Loading

Unfortunately, the beforeSend function is not documented, so I'm not sure what it's supposed to be doing. Would you please explain why you want beforeSend to return the wrapped value?

It looks like on line 471, the if statement is expecting beforeSend to return a true or false.

@kevindb kevindb changed the title Update jquery.form.js In fileUploadXhr: The beforeSend wrapper should return the wrapped return value Mar 10, 2017
@kevindb
Copy link
Member

kevindb commented Apr 11, 2017

I am closing this PR for now. It can be reopened if there is demand for this feature.

@kevindb kevindb closed this Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

need more info

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AdelRefaat @kevindb