Skip to content

Ignore JS errors in iframe scope #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

davidxi
Copy link

@davidxi davidxi commented Sep 17, 2014

Since this iframe is not exposed to outside, it is better to silent fail any JavaScript error internally. Otherwise it will surface to top.

Or there could be a option to set if ignore iframe scope error.

Since this iframe is not exposed to outside, it is better to silent fail any JavaScript error internally. Otherwise it will surface to top.

Or there could be a option to set if ignore iframe scope error.
@kevindb
Copy link
Contributor

kevindb commented Feb 22, 2017

What is the purpose of ignoring JavaScript errors? Wouldn't we want to see what errors are occurring?

@kevindb
Copy link
Contributor

kevindb commented Apr 11, 2017

I am closing this PR for now. It can be reopened if there is demand for this feature.

@kevindb kevindb closed this Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants