support for xhr.status + correctly trigger ajaxError handlers #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…status="404"> or <textarea status="404"> when using the textarea hack
…us from the iframe
|
+1 |
|
This doesn't work correctly for the default case of no status attribute on the body or textarea. In that case, the status code remains zero and causes the status text to be 'error' which triggers the error handling logic. |
|
Fixed, thanks. I wasn't testing the code without the (server-side) "status" hack as I should have ... |
|
Merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey malsup,
i did found it very limiting not having a
xhr.statuswhen doing an ajax file upload ...since there's a
<textarea>hack anyway i thought why not add another "hack" to receive thestatus(andstatusTextas well), here's what i did :statusattribute on the document root (e.g.<body>)<textarea>hack is used i check for thestatusattribute on it as wellxhr.status === 'n/a'now after adding this i discovered that even thought the
xhr.statuswas being set correctly i still had issues with theajaxErrorhandler not being triggered correctly ... thus i changed the "status" handling logic a bit and now it's working flawlessly - so i thought it might be useful for others as well :)K.