Skip to content

Conversation

@scottgonzalez
Copy link
Contributor

🎄 Here's an early Christmas present 🎁


  • Upgrades to grunt 0.4.5
  • Upgrades to grunt-jquery-content 2.0.0
  • Removes many grunt plugins which are now bundled into grunt-jquery-content
  • Removes many unused and unnecessary tasks
  • Removes directory from sample config since there's only one useful value

Requires updating WordPress plugin from grunt-wordpress 1.0.7 to gilded-wordpress 1.0.0.


Run npm install and npm prune before grunt deploy.

* Upgrades to grunt 0.4.5
* Upgrades to grunt-jquery-content 2.0.0
* Removes many grunt plugins which are now bundled into grunt-jquery-content
* Removes many unused and unnecessary tasks
* Removes directory from sample config since there's only one useful value

Requires updating WordPress plugin from grunt-wordpress 1.0.7 to
gilded-wordpress 1.0.0.
@jzaefferer
Copy link
Collaborator

This looks great. I did a local deploy and noticed that all pages got overwritten, even though no content should've changed. Is that due to the switch from grunt-wordpress to gilded-wordpress? On a second deploy nothing was changed, so its probably fine.

Otherwise, we talked about using a config.js to put stage or live URLs in there as well. Without access to grunt.config, do you have a suggestion on how to figure out what config to return? Looking at process.argv directly doesn't seem like a good idea.

@scottgonzalez
Copy link
Contributor Author

I did a local deploy and noticed that all pages got overwritten, even though no content should've changed.

To be honest, I was never able to track down why this happened. I spent a lot of time trying to not have that happen, but gave up after a while. This happened for every site that was upgraded, so it was expected that it would happen here, though I don't know what exactly changed.

Otherwise, we talked about using a config.js to put stage or live URLs in there as well. Without access to grunt.config, do you have a suggestion on how to figure out what config to return? Looking at process.argv directly doesn't seem like a good idea.

I would just do something like:

var env = "default";
var hasEnv = process.argv.indexOf( "--env" );
if ( hasEnv !== -1 ) {
    env = process.argv[ hasEnv + 1 ];
}
// get config based on env

Or something similar to parse a grunt-like var. Alternatively, you can just use an actual environment variable, which makes the code even simpler:

var env = process.env.SITE || "default";

And to run:

SITE=stage grunt deploy

@jzaefferer
Copy link
Collaborator

Okay, thanks. I think I'll go with environment variables, that's simple enough. Just have to remember to slightly change argument order.

@jzaefferer jzaefferer merged commit b197306 into jquery-validation:master Dec 24, 2014
@jzaefferer
Copy link
Collaborator

Merged, and updated the README to point to gilded-wordpress as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants